fix: scrollIntoView ending earlier than the duration given as an option #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I looked at the behavior of the methods on the @egjs/flicking, and Flicking do not end the animation earlier than the duration passed as an option, so I want to unify the behavior here. If there are any issues with the original behavior in the future, perhaps we'll add an option to support the original behavior. |
malangfox
changed the title
malangfox
added a commit
to malangfox/egjs-conveyer
that referenced
this pull request
Jun 2, 2023
…on (naver#35) * feat: add fixedDuration option * fix: make fixedDuration option to regular feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
https://codepen.io/malangfox/pen/MWPLWvV
In the above demo, when the
scrollIntoViewis triggered by pressing the button, the scroll moves for 5000ms, but when item 11 is placed at the far right end and the button is pressed, the time it takes to move to the end of the scroll area is not 5000ms.Fixing this as a bug could lead to a new issue of
scrollIntoViewbeing slow at the end of the scroll area after updating the version of Conveyer, so I would like to support the existing behavior but add an option to check the minimum/maximum scrollable distance when calculating the distance forscrollByinscrollIntoViewso that it always has the same scroll animation time.I'm currently using the
fixedDurationname as a temporary name, but I'm trying to think of another appropriate name.