feat: add useResizeObserver option #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuu0916
changed the title
daybrush
reviewed
Sep 18, 2023
packages/conveyer/src/Conveyer.ts
Outdated
| @@ -454,6 +456,16 @@ class Conveyer extends Component<ConveyerEvents> { | |||
| useNormalized: false, | |||
| })); | |||
| } | |||
| if (!IS_IE && options.useResizeObserver) { | |||
There was a problem hiding this comment.
Rather than comparing with IS_IE, compare with/without ResizeObserver.
daybrush
reviewed
Sep 21, 2023
packages/conveyer/src/Conveyer.ts
Outdated
|
|
||
| entries.forEach((entry: ResizeObserverEntry) => { | ||
| if (entry.target !== this._scrollAreaElement) { | ||
| for (let i = 0; i < items.length; i++) { |
There was a problem hiding this comment.
It would be nice to make items.length a constant.
daybrush
reviewed
Sep 21, 2023
packages/conveyer/src/Conveyer.ts
Outdated
| @@ -312,10 +316,22 @@ class Conveyer extends Component<ConveyerEvents> { | |||
| public updateItems() { | |||
| const scrollAreaElement = this._scrollAreaElement; | |||
| const itemSelector = this._options.itemSelector; | |||
| const childrenDiffer = this._childrenDiffer; | |||
There was a problem hiding this comment.
It's good to use children differ. Rather than using classes/instances. Use the function `import { diff } from "@egjs/children-differ".
daybrush
reviewed
Sep 21, 2023
packages/conveyer/src/Conveyer.ts
Outdated
| this.setItems(itemElements.map((el) => this._getItem(el))); | ||
|
|
||
| if (resizeObserver){ | ||
| const prevItemElements = this._itemElements; |
There was a problem hiding this comment.
There will be no need to create _itemElements.
Use items.map(item => item.element).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#50
Details