Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: match framework rendering with native rendering #281

Closed
wants to merge 4 commits into from

Conversation

WoodNeck
Copy link
Member

Issue

#273

Details

This PR is made to match the rendering method same with native's.
That is, when a new panel threw in, the framework should render new panels with visible ones to calculate size.
This also implements isEqualSize and isConstantSize options for framework Flickings.
The real implementation is only available for only Vue-Flicking yet.

@WoodNeck WoodNeck added 🔖3.x v3.x~ related issue ♻️Refactoring Refactoring code / structure 📦Vue2 @egjs/vue-flicking related issue labels Aug 22, 2019
@WoodNeck WoodNeck self-assigned this Aug 22, 2019
@WoodNeck WoodNeck closed this Aug 22, 2019
@WoodNeck
Copy link
Member Author

WoodNeck commented Aug 22, 2019

Close this PR due to it's not updating.
Tried isaacs/github#750 (comment), but didn't work.
image
^ This is what I've got.

So I'm gonna make another PR with the same details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔖3.x v3.x~ related issue 📦Vue2 @egjs/vue-flicking related issue ♻️Refactoring Refactoring code / structure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant