skip: apply review

src/ImReadyManager.ts

@@ -167,7 +167,7 @@ class ImReadyManager extends Component<ImReadyEvents> {
     const loader = new ElementLoader(element, options);
     const children = toArray(element.querySelectorAll<HTMLElement>(tags.join(", ")));
 
-    loader.hasLoading = children.some(el => hasLoadingAttribute(el));
+    loader.setHasLoading(children.some(el => hasLoadingAttribute(el)));
     let withPreReady = false;
 
     const childrenImReady = this.clone().on("error", e => {

src/loaders/ElementLoader.ts

@@ -11,6 +11,9 @@ export class ElementLoader<T extends HTMLElement> extends Loader<T> {
   public static EVENTS: string[] = [];
   public options!: ImReadyLoaderOptions;
 
+  public setHasLoading(hasLoading: boolean) {
+    this.hasLoading = hasLoading;
+  }
   public checkElement() {
     if (!this.hasDataSize) {
       // has not data size

src/loaders/Loader.ts

@@ -12,12 +12,12 @@ import { removeEvent, hasSizeAttribute, hasLoadingAttribute, addEvent } from "..
 export default abstract class Loader<T extends HTMLElement = any> extends Component<ImReadyLoaderEvents> {
   public static EVENTS: string[] = [];
   public options!: ImReadyLoaderOptions;
-  public isReady = false;
-  public isPreReady = false;
-  public hasDataSize = false;
-  public hasLoading = false;
   public abstract checkElement(): boolean;
   protected element!: T;
+  protected isReady = false;
+  protected isPreReady = false;
+  protected hasDataSize = false;
+  protected hasLoading = false;
 
   constructor(element: HTMLElement, options: Partial<ImReadyLoaderOptions> = {}) {
     super();

test/unit/utils.ts

@@ -72,6 +72,5 @@ export function expectOrders(events: EventType[], values: string[]) {
   // Then
   const eventNames = events.map(e => e.eventType);
 
-  console.log(eventNames);
   expect(eventNames).to.be.deep.equals(values);
 }