Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add destroy method #152

Closed
sculove opened this issue Mar 11, 2016 · 0 comments
Closed

Add destroy method #152

sculove opened this issue Mar 11, 2016 · 0 comments
Assignees
@netil
Labels
enhancement flicking
Milestone
1.2.0

Comments

@sculove
Copy link
Contributor

sculove commented Mar 11, 2016

Description

need to destroy method to release resource
@netil netil self-assigned this Mar 21, 2016
@mixed mixed modified the milestone: 1.2.0 Mar 24, 2016
netil added a commit to netil/egjs that referenced this issue May 27, 2016
@netil
feat(Flicking) : Add destroy() method
bb25a1c 
To release resources and events attached

Ref naver#152
@netil netil mentioned this issue May 27, 2016
Closed
netil added a commit to netil/egjs that referenced this issue May 27, 2016
@netil
test(Flicking) : Update of manual test
e776ef3 
Newly added methods execution button

Ref naver#152
@netil netil closed this as completed in b9a2edc May 30, 2016
jongmoon pushed a commit to jongmoon/egjs that referenced this issue Jun 8, 2016
fix(Flicking): Re-select target panel on .destroy()
c6e223c 
$list elements order aren't same as init.
To restoring it's original css class/style, need to be selected panel order like init.
If panels are added to fulfill minimum count, also should be removed on .destroy()

Ref naver#152
jongmoon pushed a commit that referenced this issue Jun 10, 2016
fix(Flicking): Re-select target panel on .destroy()
fd00a4e 
$list elements order aren't same as init.
To restoring it's original css class/style, need to be selected panel order like init.
If panels are added to fulfill minimum count, also should be removed on .destroy()

Ref #152
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@netil netil

Labels
enhancement flicking
Projects
None yet
Milestone
1.2.0
Development

No branches or pull requests
3 participants
@mixed @sculove @netil