fix(Flicking): Getting previous panel index number on non-circular mode #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added to assign panel.no value when instantiate with defaultIndex option value Ref naver#116
|
I'm still confusing words (panel.index and panel.no) whenever I see the code. Anyway LGTM! |
var f = new eg.Flicking("#mflick", {
defaultIndex: 0,
circular : false
});
f.getPrevIndex(); //nullThe API document states However, when |
|
@kishu agree. I'll update api comments in case of null. |
Added null return type on api comments Merged master update
Added null return type on api comments
|
LGTM |
happyhj
added a commit
to happyhj/egjs
that referenced
this pull request
Feb 15, 2016
# The first commit's message is: test(scrollEnd): add "scroll after rotate" test run test for internal logic only on PhantomJS ref naver#123 # The 2nd commit message will be skipped: # Update Gruntfile.js # The 3rd commit message will be skipped: # chore(bower): change outlayer version # # ref naver#87 # The 4th commit message will be skipped: # feat(flicking): Support previewPadding resize # # Support change of previewPadding option after the initialization # # Ref naver#13 # Close naver#105 # The 5th commit message will be skipped: # fix(Flicking): Getting previous panel index number on non-circular mode # # Added to assign panel.no value when instantiate with defaultIndex option value # # Fix naver#116 # Close naver#117 # The 6th commit message will be skipped: # feat(infiniteGrid): Change the order of item in case of prepending # # ref naver#98 # The 7th commit message will be skipped: # fix(infiniteGrid): According to viewport, item order is different # # sometimes, item order is wrong because outerHeight is floating value. # # ref naver#102 # The 8th commit message will be skipped: # feat(infiniteGrid): Change items to be removed in case of prepending # # ref naver#101 # The 9th commit message will be skipped: # feat(infiniteGrid): remove param.croppedDistance in prepend event # # ref naver#99
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#116
Details
Added to assign panel.no value when instantiate with defaultIndex option value
Preferred reviewers
@jongmoon @kishu