chore(dev-env): Remove bower on dev env #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed bower install for dev setup Updated all 'bower_components' reference Ref naver#391
|
Need to be checked
|
Update on cssPrefix jQuery version
mixed
reviewed
Nov 1, 2016
| @@ -6,7 +6,7 @@ | |||
| <style> | |||
| #el {font-size:20pt} | |||
| </style> | |||
| <script src="../../bower_components/jquery/jquery.js"></script> | |||
| <script src="https://code.jquery.com/jquery-1.7.2.min.js"></script> | |||
There was a problem hiding this comment.
It seems to be slow beacuse get a network. and is different case. I think that be better merged jquery.
There was a problem hiding this comment.
Trying to figure out install multiple version of same package as dependency, but actually there's no appropriate solution for that.
Having a copy of legacy jQuery at unit/lib seems to be best for now.
For cssPrefix only test purpose
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#391
Details
Removed bower install for dev setup
Updated all 'bower_components' reference
Preferred reviewers
@naver/egjs-dev