Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VENOM-444: Fix about dialog at login #444

Merged
merged 1 commit into from
Nov 23, 2018

Conversation

naxuroqa
Copy link
Owner

  • Cast active window to ApplicationWindow
  • Set venom-symbolic as icon in the about dialog

* Cast active window to `ApplicationWindow`
* Set `venom-symbolic` as icon in the about dialog
@codecov-io
Copy link

codecov-io commented Nov 23, 2018

Codecov Report

Merging #444 into release-0.5.1 will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##           release-0.5.1    #444   +/-   ##
=============================================
  Coverage           5.91%   5.91%           
=============================================
  Files                 78      78           
  Lines               5259    5259           
=============================================
  Hits                 311     311           
  Misses              4948    4948
Impacted Files Coverage Δ
src/view/AboutDialog.vala 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b983ea...9d699f9. Read the comment docs.

@naxuroqa naxuroqa merged commit 9d699f9 into release-0.5.1 Nov 23, 2018
@naxuroqa naxuroqa deleted the VENOM-444_fix_about_dialog branch November 23, 2018 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants