Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External return type(s) for getting fee schedule #136

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

amarinkovic
Copy link
Member

@amarinkovic amarinkovic commented Jun 12, 2024

Due to a web3j bug limitation, not being able to decode structs containing dynamic arrays, return type is changed here. Call to the getFeeSchedule now just returns the two arrays, unwrapping them from the original FeeSchedule struct.

Copy link
Contributor

@kevin-fruitful kevin-fruitful left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@amarinkovic amarinkovic mentioned this pull request Jun 13, 2024
@amarinkovic amarinkovic merged commit c42e32e into dev Jun 13, 2024
4 checks passed
@amarinkovic amarinkovic deleted the get_fee_external_return_type branch June 13, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants