Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setChannel(): use lastConf #11

Merged
merged 1 commit into from
Sep 9, 2019
Merged

setChannel(): use lastConf #11

merged 1 commit into from
Sep 9, 2019

Conversation

nayuta-ueno
Copy link
Contributor

setChannel(): use lastConf if StoredBlock#getHeight() failed.

@nayuta-ueno
Copy link
Contributor Author

relation
nayutaco/lns_arduino_library#8

@nayuta-ueno
Copy link
Contributor Author

おそらくだが、setChannel(minedHash)のminedHashがbitcoinjが保存しているspvchainファイルよりも古くなった場合にStoredBlock#getHeight()が失敗しているのではなかろうか。
そのため、Lightning Shieldをテストしている期間程度では現象が出なかったのだろうと思われる。

@nayuta-ueno nayuta-ueno merged commit d992a44 into master Sep 9, 2019
@nayuta-ueno nayuta-ueno deleted the bj_conf branch September 9, 2019 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nayuta-ueno