feat: rust SVC example #3

tarsisexistence · 2021-11-06T12:59:59Z

No description provided.

…c example

rust/examples-frontend/videoroom/src/index.ts

tarsisexistence · 2021-11-06T13:17:59Z

rust/examples-frontend/echo/index.html

-        <figcaption>Receive preview</figcaption>
-    </figure>
-</div>
+        <figure>


dunno how to run lint

Why did you modify it at all?

This project is too simple to have HTML linter

I touched that file recently
then copy-pasted this file from master and here is result ...

tarsisexistence · 2021-11-06T15:52:13Z

it's not SVC yet, it's kinda simulcast

rust/examples/svc.rs

nazar-pc

Overall, it would be much easier to review if there was just 2 commits:

Copies echo example or whatever you take as a reference with 0 modifications
Changes necessary for SVC/Simulcasing features

Also can you submit fixes for resolution typos upstream as a standalone PR, please?

nazar-pc · 2021-11-06T22:06:23Z

rust/examples-frontend/echo/index.html

-        <figcaption>Receive preview</figcaption>
-    </figure>
-</div>
+        <figure>


Why did you modify it at all?

This project is too simple to have HTML linter

nazar-pc · 2021-11-06T22:06:53Z

rust/examples-frontend/echo/src/index.ts

+	action: 'Init';
+	consumerTransportOptions: TransportOptions;
+	producerTransportOptions: TransportOptions;
+	routerRtpCapabilities: RtpCapabilities;


Why these formatting changes? Please keep current code style untouched.

it was made by IDE :c

it doesn't even show that master and my branch differs

rust/examples-frontend/svc/index.html

rust/examples-frontend/svc/src/index.ts

nazar-pc · 2021-11-06T22:13:20Z

rust/examples-frontend/svc/src/index.ts

+
+                    if (producer.kind === 'video') {
+                        videoProducer = producer;
+                        maxSpatialLayer = videoProducer.rtpParameters.encodings ?  videoProducer.rtpParameters.encodings.length - 1 : -1


Check if this works in Firefox, the order might be inverted there

rust/examples-frontend/svc/src/index.ts

Co-authored-by: Nazar Mokrynskyi <nazar@mokrynskyi.com>

tarsisexistence · 2021-12-05T21:36:08Z

@nazar-pc should we send message back server->client with updated preferred consumer layers, so we won't update those values locally on client?

…is not created yet

nazar-pc

Looks pretty good, though I didn't test it yet.

General comments:

Use formatting from node/.eslintrc.js in TS code
Use standard Rust formatting for Rust file
Squash history such that the first commit copy-pastes echo example with 0 changes and second commit adds required changes for this example, such that it is much easier to review comparing to current 27 commits

rust/examples-frontend/svc-simulcast/package.json

nazar-pc · 2021-12-12T18:54:45Z

rust/examples-frontend/svc-simulcast/src/index.ts

+
+                // And create producers for all tracks that were previously requested
+                for (const track of mediaStream.getTracks()) {
+                    const codec = track.kind === 'video' ? device.rtpCapabilities.codecs?.find((codec) => codec.mimeType.toLowerCase() === 'video/vp9') ?? device.rtpCapabilities.codecs?.find((codec) => codec.mimeType.toLowerCase() === 'video/vp8') : undefined


VP9 SVC only works in Chrome, probably worth checking that or enable VP9 SVC only with special query parameter, so that it always works correctly by default.

works in WebKit for me too

WebKit (Safari) still doesn't support VP9 at all by default, let alone SVC.

rust/examples-frontend/svc-simulcast/webpack.config.js

nazar-pc · 2021-12-12T19:00:55Z

rust/examples-frontend/svc-simulcast/src/index.ts

+            newPreferredSpatialLayer = preferredSpatialLayer - 1;
+            newPreferredTemporalLayer = temporalLayers - 1;
+        } else {
+            newPreferredSpatialLayer = spatialLayers - 1;
+            newPreferredTemporalLayer = temporalLayers - 1;


Math on these lines seems to be incorrect

why?
that's an implementation of mediasoup-demo as we agreed before

temporal can be decreased, we don't touch spatial

we try to decrease spatial because temporal is already 0.

we set max layers for both because they both were on 0.

First branch here is correct, second branch is not because when it switches spatial layer down, it should switch temporal back to the highest value. Third branch simply allows layers to go into negative values instead of wrapping around.

you misread the variable name... it doesn't go into a negative one...

Ah, indeed. then maxSpatialLayer would be way less confusing than spatialLayers - 1. And similarly increaseLayer should use those variables instead of 2.

rust/examples/svc-simulcast.rs

tarsisexistence · 2021-12-18T20:40:44Z

if everything is fine, I'll just do the squash @nazar-pc

nazar-pc · 2021-12-18T22:10:39Z

I need squash the way I described to review it, there is 35 individual changes, it is hard to overlay them in my head to understand what the state of the codebase is as of the each individual commit. Having copy-paste of existing demo and modifications separately reduces the scope of review drastically.

nazar-pc · 2021-12-18T22:14:42Z

rust/examples-frontend/svc-simulcast/src/index.ts

+        if (isFirefox) {
+            setPreferredLayers(preferredSpatialLayer > 0 ? preferredSpatialLayer - 1 : spatialLayers - 1)
+            return
+        }


I don't understand what this is and this will go into negative numbers as well unless I'm missing something.

Firefox supports both temporal and spatial layers just fine.

nazar-pc · 2022-04-03T23:58:24Z

versatica#809 is open upstream, thanks!

tarsisexistence added 9 commits October 22, 2021 00:41

feat: add svc skeleton

3703faa

fix: typo of video res

94743e7

feat: simple client

d4e7252

feat: base styles

25a7d3f

feat: change max spatial layer on button click

03e9480

fix: max spatial layer limit

b49c7c6

feat: layers for svc

05adfed

refactor: move svc frontend code from echo example into standalone sv…

b720a88

…c example

feat: server svc example

3061b4f

tarsisexistence commented Nov 6, 2021

View reviewed changes

rust/examples-frontend/videoroom/src/index.ts Show resolved Hide resolved

tarsisexistence added 2 commits November 6, 2021 15:01

fix: 1270 -> 1280 resolution typo

b6aaeb0

refactor: rename setMaxSpatialLayer

85b6635

tarsisexistence commented Nov 6, 2021

View reviewed changes

feat: vp9 svc support

0262fb3

tarsisexistence commented Nov 6, 2021

View reviewed changes

rust/examples/svc.rs Outdated Show resolved Hide resolved

nazar-pc requested changes Nov 6, 2021

View reviewed changes

tarsisexistence and others added 8 commits November 7, 2021 16:32

refactor: replace innerHTML with textContent

1804c8f

Co-authored-by: Nazar Mokrynskyi <nazar@mokrynskyi.com>

refactor: setMaxSpatialLayer with arg value

5689731

refactor: rename svc example into svc-simulcast

0ff8725

chore: tweak simulcast encodings

e8af3a1

feat(checkpoint): send preferred layers to the server

26e754e

Merge remote-tracking branch 'nazar-pc/v3' into rust-svc-example

314909c

feat: handle set preferred consumer layers

1ea637f

chore: remove logs

fa9563e

tarsisexistence requested a review from nazar-pc December 5, 2021 21:36

tarsisexistence added 3 commits December 11, 2021 13:48

fix: webpack config issue

cc97a6f

feat: rework increase/decrease spatial and temporal layers

808e729

feat: render temporal layer info

7ee09ff

tarsisexistence added 4 commits December 11, 2021 14:39

fix: render correct spatial and temporal layer on init

897d02a

fix: switch from 2-2 to 0-0 on click increase("up")

2b9ddf5

fix: throw an error on set preferred layers attemp if video consumer …

a6ac9a2

…is not created yet

refactor: proper naming

9915e2b

nazar-pc requested changes Dec 12, 2021

View reviewed changes

tarsisexistence added 8 commits December 18, 2021 21:16

Merge remote-tracking branch 'nazar-pc/v3' into rust-svc-example

4f1ec15

fix: minors

7cd042c

chore: bump dependencies

3257950

feat: bump all dependencies of all rust frontend examples

afe4cc7

feat: add vp9 rtpcodeccapability

99f1b54

fix: handle firefox to vp8 codec and change only spatial layer

aee109b

chore: add eslint config

1245a1b

fix: cargo fmt

d8c1e3e

tarsisexistence requested a review from nazar-pc December 18, 2021 20:41

nazar-pc reviewed Dec 18, 2021

View reviewed changes

nazar-pc mentioned this pull request Apr 3, 2022

Rust SVC/Simulcast example versatica/mediasoup#809

Merged

nazar-pc closed this Apr 3, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: rust SVC example #3

feat: rust SVC example #3

tarsisexistence commented Nov 6, 2021

tarsisexistence Nov 6, 2021

nazar-pc Nov 6, 2021

tarsisexistence Nov 7, 2021

tarsisexistence commented Nov 6, 2021

nazar-pc left a comment

nazar-pc Nov 6, 2021

nazar-pc Nov 6, 2021

tarsisexistence Nov 7, 2021

nazar-pc Nov 6, 2021

tarsisexistence commented Dec 5, 2021

nazar-pc left a comment

nazar-pc Dec 12, 2021

tarsisexistence Dec 18, 2021

nazar-pc Dec 19, 2021

nazar-pc Dec 12, 2021

tarsisexistence Dec 18, 2021

nazar-pc Dec 18, 2021

tarsisexistence Dec 19, 2021

nazar-pc Dec 19, 2021

tarsisexistence commented Dec 18, 2021 •

edited

Loading

nazar-pc commented Dec 18, 2021

nazar-pc Dec 18, 2021

nazar-pc commented Apr 3, 2022

feat: rust SVC example #3

feat: rust SVC example #3

Conversation

tarsisexistence commented Nov 6, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tarsisexistence commented Nov 6, 2021

nazar-pc left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tarsisexistence commented Dec 5, 2021

nazar-pc left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tarsisexistence commented Dec 18, 2021 • edited Loading

nazar-pc commented Dec 18, 2021

Choose a reason for hiding this comment

nazar-pc commented Apr 3, 2022

tarsisexistence commented Dec 18, 2021 •

edited

Loading