-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for pyright #647
Comments
@MarcoGorelli is it supported? |
Hi - I'd expect it to work out-of-the-box If not, please do let me know |
So I tested it and it works, but not in a way which I need it to work. I was unable so far to find any workaround. The issue is that nbqa assumes that all files may be evaluated independently, which is not true for type checkers, especially not for pyright. What I'm missing in this tool is the ability to convert notebook to python files and keep them. I see that currently this feature can't be used independently and also those generated python files are instantly removed. |
seems like a reasonable request - reopening then, thanks for the ping! |
Hello, I would like to understand if this limitation also applies to |
In case it's helpful I'm able to run
and it correctly picks out all the notebooks in the examples directory. Imports from the notebooks to the rest of the local code work. This seems to work well for us, and now avoids a extra steps of |
What needs doing:
.pre-commit-hooks.yaml
docs/examples.rst
requirements-dev.txt
tests/tools
(seetests/tools/test_yapf.py
for an example)The text was updated successfully, but these errors were encountered: