Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ruff tests by running the quiet mode #847

Merged
merged 1 commit into from
Mar 17, 2024

Conversation

GaetanLepage
Copy link
Contributor

The latest version of ruff (0.3.3) does not have an empty stdout when succesfull.
This can be restored by passing the --quiet flag.

Copy link
Collaborator

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarcoGorelli MarcoGorelli merged commit 156d9b0 into nbQA-dev:main Mar 17, 2024
11 checks passed
@MarcoGorelli
Copy link
Collaborator

@all-contributors please add @GaetanLepage for tests

Copy link
Contributor

@MarcoGorelli

I've put up a pull request to add @GaetanLepage! 🎉

@GaetanLepage
Copy link
Contributor Author

Thanks for merging !
Is a new release planned soon ?

@MarcoGorelli
Copy link
Collaborator

do you need a release, given that it only affects tests?

@GaetanLepage
Copy link
Contributor Author

This would let us update ruff on nixpkgs: NixOS/nixpkgs#296256
We can still cherry-pick this patch. I fully understand that this might not be worth a release for you.

@MarcoGorelli
Copy link
Collaborator

no worries, just made a new one

@GaetanLepage
Copy link
Contributor Author

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants