Fixed Verify Breakpoints #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
requested changes
Jun 8, 2020
| @@ -149,3 +149,7 @@ def main() -> NoReturn: | |||
| # If a user encounters a traceback that should be a fatal issue | |||
| print("dashmips encountered an error!", file=sys.stderr) | |||
| print(ex, file=sys.stderr) | |||
| except KeyboardInterrupt as ex: | |||
| # Program should be closed | |||
| print("Program terminated.") | |||
There was a problem hiding this comment.
We should do a run over all the python we've changed uses the logger instead of printing and make sure the logger prints to stderr when enabled
For now lets make this print(..., file=sys.stderr) use stderr.
| local_breakpoints.append(real_line) | ||
| elif real_line is None and is_known_file: | ||
| local_breakpoints.append(-1) |
There was a problem hiding this comment.
Let's document this, right here in a comment what -1 means and maybe a note in the wiki
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.