Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "signed" filed to the "cassh status" command #14

Closed
xakraz opened this issue Aug 25, 2017 · 2 comments
Closed

Add a "signed" filed to the "cassh status" command #14

xakraz opened this issue Aug 25, 2017 · 2 comments
Assignees

Comments

@xakraz
Copy link
Contributor

xakraz commented Aug 25, 2017

Context

When you add a key, you can see explicitly that the status is Pending

$ cassh status
{
    "expiration": "1970-01-01 01:00:00 (UTC+0000)", 
    "realname": "Firstname Lastname", 
    "ssh_key_hash": "2048 e8:00:ed:f3:ae:8c:d1:65:e6:3b:48:8f:d5:84:fd:f5 ", 
    "status": "PENDING", 
    "username": "username"
}

After an admin "activate" a user, same result, we can clearly see the status:

 $ cassh status
Please type your LDAP password (user=Xavier Krantz): 
{
    "expiration": "1970-01-01 01:00:00 (UTC+0000)", 
    "realname": "Xavier Krantz", 
    "ssh_key_hash": "2048 e8:00:ed:f3:ae:8c:d1:65:e6:3b:48:8f:d5:84:fd:f5 ", 
    "status": "ACTIVE", 
    "username": "username"
}

However, currently there is no way to know if the key is signed ...
Even if we can guess it, since we have an expiration date that is defined in the future:

$ cassh status
{
    "expiration": "2017-08-26 11:29:19 (UTC+0000)", 
    "realname": "Firstname Lastname", 
    "ssh_key_hash": "2048 e8:00:ed:f3:ae:8c:d1:65:e6:3b:48:8f:d5:84:fd:f5 ", 
    "status": "ACTIVE", 
    "username": "username"
}

Feature Request:

It could be nice to have an explicit field for quick understanding, especially for users who are not very familiar with CLI and ssh practices. Maybe a new field or update the status filed to SIGNED ?

@nbeguier nbeguier self-assigned this Aug 25, 2017
@nbeguier
Copy link
Owner

Good idea, I'll add two more status : SIGNED and EXPIRED

@nbeguier
Copy link
Owner

{
"expiration": "2017-08-26 11:51:58",
"realname": "Nicolas Beguier",
"ssh_key_hash": "2048 7b:5f:73:66:68:5f:73:fe:09:a7:5c:3e:72:xx:d1:97 ",
"status": "SIGNED",
"username": "username"
}

jffz pushed a commit to jffz/cassh that referenced this issue Jun 13, 2019
[CI] Fixed release tasks and Travis config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants