Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

german translations part2 #13

Merged
merged 4 commits into from
Dec 19, 2022
Merged

german translations part2 #13

merged 4 commits into from
Dec 19, 2022

Conversation

Constey
Copy link

@Constey Constey commented Dec 19, 2022

Hi @nbelyh,

i've added the missing strings within the manifest and the other files. should be all now :-)
(Did not translate the console.log messages...)
I'm somehow to stupid to auto merge our commits, so i've added your updated package.json within my commit.

Kind regards,
Constantin

@nbelyh
Copy link
Owner

nbelyh commented Dec 19, 2022

Thank you so much. I've just included one a [dependabot] pull request. Will resolve the conflict and merge.

@nbelyh nbelyh merged commit ff5b9c7 into nbelyh:master Dec 19, 2022
@nbelyh
Copy link
Owner

nbelyh commented Dec 19, 2022

Fixed the build also, so that it does not try to deploy every PR to Github releases, but just builds 😅

@nbelyh
Copy link
Owner

nbelyh commented Dec 19, 2022

@Constey I've erroneously committed the PR from [Dependabot], that updated one of SPFx modules to broken 1.16.0 while the rest now are 1.15.2, reverted. All must be updated at once (later). Also one string was missing in en-us version (label for the "Configure" button), maybe merged incorrectly. Now should be okay. Please take the latest after merge, should be fine.

@Constey
Copy link
Author

Constey commented Dec 20, 2022

@Constey I've erroneously committed the PR from [Dependabot], that updated one of SPFx modules to broken 1.16.0 while the rest now are 1.15.2, reverted. All must be updated at once (later). Also one string was missing in en-us version (label for the "Configure" button), maybe merged incorrectly. Now should be okay. Please take the latest after merge, should be fine.

maybe i've missed it - but i've tested the version - seems good so far :-)

@nbelyh
Copy link
Owner

nbelyh commented Dec 20, 2022

@Constey The size of the package increased to 2MB instead of 300KB (i.e. 7x times) with that accepted Dependabot PR (now reverted back, so it should be fine). This is a problem with SPFx 1.16.0 (they forgot to turn on the minification there). It was fixed in 1.16.1, but all SPFx modules need to be updated at once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants