Terraform 0.12 and Testing #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actual operation doesn't require sorted keys, but testing does. Notably, python 2.7 and 3 end up with different output if not sorted.
Seems to work fine in both 2.7 and 3.x.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle Terraform 0.12 TFState format. Keeps backward-compatibility to ease transition. Also needed to drop
-input=falseflag onterraform state pullbecause it wasn't recognized by Terraform 0.12-beta2.Also adds some basic acceptance test infrastructure - simply checks if the script output changed. I didn't feel it was necessary to add the overhead of a unit test framework for a single script file... but I'd accept a PR if someone else feels like writing it.