Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate issue #9 #10

Closed
wants to merge 15 commits into from
Closed

Conversation

nbigaouette
Copy link
Owner

DO NOT MERGE

This MR is meant to investigate issue #9 and trigger the CI.

@coveralls
Copy link

Coverage Status

Coverage decreased (-6.4%) to 86.961% when pulling 1aafc10 on 9-coveralls-wrong-source-links into 1af1e4f on master.

@codecov-io
Copy link

codecov-io commented Dec 9, 2016

Current coverage is 93.38% (diff: 100%)

Merging #10 into master will not change coverage

@@             master        #10   diff @@
==========================================
  Files            17         17          
  Lines          1677       1677          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           1566       1566          
  Misses          111        111          
  Partials          0          0          

Powered by Codecov. Last update 1af1e4f...92ae711

@nbigaouette
Copy link
Owner Author

With --exclude-pattern=/.cargo,serde_type.rs (1aafc10), coveralls gives back proper listing of source file (with src prefix).

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.381% when pulling 1e0bdab on 9-coveralls-wrong-source-links into 1af1e4f on master.

@nbigaouette
Copy link
Owner Author

With --exclude-pattern=target,/.cargo (1e0bdab), coveralls fails to properly list files.

@coveralls
Copy link

Coverage Status

Coverage decreased (-76.4%) to 16.934% when pulling d8f23cd on 9-coveralls-wrong-source-links into 1af1e4f on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.381% when pulling 61249de on 9-coveralls-wrong-source-links into 1af1e4f on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.381% when pulling 7be6c37 on 9-coveralls-wrong-source-links into 1af1e4f on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.381% when pulling ef40399 on 9-coveralls-wrong-source-links into 1af1e4f on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-6.4%) to 86.961% when pulling 98560f4 on 9-coveralls-wrong-source-links into 1af1e4f on master.

@nbigaouette
Copy link
Owner Author

Using --exclude-path seemed to work! Problem was probably due to excluding the covered files...

@coveralls
Copy link

Coverage Status

Coverage decreased (-6.4%) to 86.961% when pulling 8a3b425 on 9-coveralls-wrong-source-links into 1af1e4f on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.381% when pulling a1d809f on 9-coveralls-wrong-source-links into 1af1e4f on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.381% when pulling 77273e8 on 9-coveralls-wrong-source-links into 1af1e4f on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.381% when pulling 92ae711 on 9-coveralls-wrong-source-links into 1af1e4f on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.381% when pulling c769369 on 9-coveralls-wrong-source-links into 1af1e4f on master.

@nbigaouette
Copy link
Owner Author

The problem can't seem to be fixed from kcov. This

kcov --verify --coveralls-id=$TRAVIS_JOB_ID --exclude-pattern='/.cargo,target' target/kcov target/debug/gitlab_api-*

would be enough, and one has to set the Git repo sub directory directly on coveralls.

On coveralls, clicking on the file that is reported missing and making sure one is logged in, this page shows up:

111d340c-be18-11e6-966d-d70584d7b9d4

@nbigaouette nbigaouette closed this Dec 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants