Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .unbind() to store.bind.js. #7

Closed
wants to merge 1 commit into from
Closed

Add .unbind() to store.bind.js. #7

wants to merge 1 commit into from

Conversation

aensley
Copy link

@aensley aensley commented Jun 26, 2013

No description provided.

@nbubna
Copy link
Owner

nbubna commented Jun 26, 2013

Ok, i pushed some changes. They wreck this [flawed] pull request thought, so i'm gonna close it. :)

@nbubna nbubna closed this Jun 26, 2013
@aensley
Copy link
Author

aensley commented Jun 26, 2013

They wreck this [flawed] pull request though

Good. :-p

@aensley
Copy link
Author

aensley commented Jun 26, 2013

Your change works perfectly. Both .on() and .off(). I love the namespacing. Makes my code much cleaner. Thank you!

@nbubna
Copy link
Owner

nbubna commented Jun 26, 2013

Glad to help. Be wary of #8 and you should be fine. Hopefully i'll get that fixed soon.

@nbubna
Copy link
Owner

nbubna commented Jun 26, 2013

Oh, out of curiosity, you're not using this in IE8 are you? I'm wondering if it's even worth keeping the attachEvent support around, since their storage events in IE8 are so broken anyway. It'd be easier to just support IE9+.

@aensley
Copy link
Author

aensley commented Jun 26, 2013

Thanks for the heads up. Fortunately, I'm always listening to specific keys even in the namespace so #8 shouldn't be a problem for me.

I'm only supporting IE9+ anyway, so I don't need the attachEvent support. Don't know if other devs might though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants