Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting of pve_unit useless? #19

Closed
wopfel opened this issue Jul 30, 2020 · 3 comments · Fixed by #23
Closed

Setting of pve_unit useless? #19

wopfel opened this issue Jul 30, 2020 · 3 comments · Fixed by #23
Assignees
Labels
enhancement New feature or request

Comments

@wopfel
Copy link
Contributor

wopfel commented Jul 30, 2020

Hi, in the service.conf sample file there are some lines

pve_unit = "%"

But there's no reference to pve_unit in the command.conf file. Should this be related to the -M switch?

Kind regards,
Bernd

@nbuchwitz
Copy link
Owner

Good catch! This was used in an older release, but is not relevant anymore. There is the argument -M for changing the unit to megabyte instead of percent.

@nbuchwitz nbuchwitz added the enhancement New feature or request label Jul 30, 2020
@wopfel
Copy link
Contributor Author

wopfel commented Jul 30, 2020

All right. So would you accept another PR? I'd just delete the pve_unit lines from the config file...

@nbuchwitz
Copy link
Owner

That would be more than welcome :-)

wopfel added a commit to wopfel/check_pve that referenced this issue Jul 30, 2020
The pve_unit setting was used in an older release, but is not relevant anymore.

Closes nbuchwitz#19.
nbuchwitz pushed a commit that referenced this issue Jul 31, 2020
The pve_unit setting was used in an older release, but is not relevant anymore.

Closes #19.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants