Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* Shuffle agents before sorting. #28

Merged
merged 1 commit into from
Aug 6, 2017
Merged

Conversation

audreyt
Copy link
Contributor

@audreyt audreyt commented Aug 6, 2017

Without this fix, on Safari (Mac), "grudger" ends up
always dominating on step 4, not just sometimes.

  Without this fix, on Safari (Mac), "grudger" ends up
  always dominating on step 4, not just sometimes.
@ncase ncase merged commit 71986e4 into ncase:gh-pages Aug 6, 2017
@ncase
Copy link
Owner

ncase commented Aug 6, 2017

Thank you so much! I was never able to figure out how replicate this bug on my own, let alone fix it. :)

@jkoelling
Copy link

This fixes #13. I knew the randomized draw wasn't perfect, but I'd not have guessed that it leads to the Grudger always winning depending on the browser. Always good to learn a new thing about what's specified in the standards and what's up to the browser implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants