Basic housekeeping #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I used the command below:
find . -not \( \
-name "*.mp3" -prune -o \
-name "*.png" -prune -o \
-name "*.ttf" -prune -o \
-name .svn -prune -o \
-name .git -prune \
\) -type f -print0 | \
xargs -0 sed -i "s/[[:space:]]*$//"
I used the command below:
find . -not \( \
-name "*.mp3" -prune -o \
-name "*.png" -prune -o \
-name "*.ttf" -prune -o \
-name .svn -prune -o \
-name .git -prune \
\) -type f -print0 | \
xargs -0 sed -i '$a\'
References:
http://stackoverflow.com/a/729795
http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_206
EditorConfig helps developers define and maintain consistent coding styles between different editors and IDEs. Reference: http://editorconfig.org/
The Unicode Standard permits the BOM in UTF-8, but does not require or recommend its use. Reference: https://en.wikipedia.org/wiki/Byte_order_mark#UTF-8 http://www.unicode.org/versions/Unicode5.0.0/ch02.pdf
The indentation rules in the source code were mixed with tabs and spaces * 4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, my name is Hyeon Kim. And I'm currently translating this game in Korean with @xnuk. But we noticed that this game cannot be properly run under CJK environment, so I made some basic housekeeping changed before we start translation.
Strip trailing whitespaces
Trailing whitespaces are redundant and causes meaningless diffs with some editors. Removing it.
Add line feed at the end of files
By the POSIX standard, all text files should contain "newline" at the end of file. Adding it.
References
Add
<!DOCTYPE html>in front of the pageSince this game uses WebGL and
<canvas>, the index.html should be declared as a HTML5 documentbut it does not. Explicitly specifying it by adding docstring in front of the index.html
Add an
.editorconfigfileEditorConfig helps developers define and maintain consistent coding styles between different editors and IDEs. See http://editorconfig.org for the further information
Specify
index.html's encoding as UTF-8Currently index.html does not have
<meta charset>tag. It will prevent CJK users from seeing their own language properly. We need it.Remove BOM
The Unicode Standard permits the BOM in UTF-8, but does not require or recommend its use. Byte order has no meaning in UTF-8. Removing it.
Reference
Unify the indentation
The indentation rules in the source code were mixed with tabs and spaces * 4. Unifying it with tabs.
Translation is working in progress at
koreanbranch of simnalamburt/wbwwb-kr.