Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translation_FR #7

Merged
merged 2 commits into from
Sep 8, 2017
Merged

translation_FR #7

merged 2 commits into from
Sep 8, 2017

Conversation

GolfRomeoEchoGolf83
Copy link
Contributor

Text translation done in french.

(does "peep" stands for a sound or a word or something else I don't catch ?)

Text translation done in french.

(does "peep" stands for a sound or a word  or something else I don't catch ?)
@ncase
Copy link
Owner

ncase commented Feb 28, 2017

Hi @GolfRomeoEchoGolf83, thanks so much for helping! Just a few comments before I can pull:

  1. "Peep" is slang for person, not "noise". So the translation shouldn't be "bruit". Sorry for the mixup!
  2. "Pti criquet <3" – is "pti" short for "petit"?
  3. "outtaHere": "yeah git on outta here" This line was not translated! It's English slang again, sorry. "yeah git on outta here" --> "yeah, get out of here"

Many thanks again!

1. peep = "gars" instead of "bruit"
2. "Petit" instead of "Ptit"
3. git outta here = "dégage de là"
@GolfRomeoEchoGolf83
Copy link
Contributor Author

Hi @ncase

Thanks for your review, I wasn't sure about slang 😃

  1. many thanks, I thought about it but wasn't sure.
  2. yes, but while reading, I think a clean version with "petit" instead of "p'tit" could be better
  3. many thanks, I thought it was "Git"Hub related 😄

Wish you a good day 🙏

@GolfRomeoEchoGolf83
Copy link
Contributor Author

@ncase Is everything ok ?

@ncase
Copy link
Owner

ncase commented Mar 4, 2017

Thanks for the clarifications, @GolfRomeoEchoGolf83! I'm currently away someplace with very bad internet connection, so I won't be able to integrate the French translation until next next week. I'll ping you again once I'm back, thanks for your patience!

@Gadal
Copy link

Gadal commented Aug 24, 2017

bump.

(@ncase Hopefully you had a pleasant trip!)

@ncase ncase merged commit e6f1815 into ncase:master Sep 8, 2017
@ncase
Copy link
Owner

ncase commented Sep 8, 2017

Ack, sorry for leaving this hanging @GolfRomeoEchoGolf83! (and thanks for the bump, @Gadal) I just pulled the French strings, it'll be a bit longer, but I'll make & upload the French WBWWB eventually. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants