Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export metadata #3

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Export metadata #3

wants to merge 1 commit into from

Conversation

ncave
Copy link
Owner

@ncave ncave commented May 25, 2019 •
edited
Loading

Exports metadata-only BCL binaries:

git clone https://github.com/ncave/fsharp.git
cd fsharp
git checkout export
bash fcs/build.sh

Binaries will be exported to temp/metadata.

@alfonsogarciacaro
Copy link

Awesome, thanks! Very happy that we don't have to wait for the FCS to be updated with visualfsharp changes now :)

@ncave
Copy link
Owner Author

ncave commented Aug 5, 2019

@alfonsogarciacaro Rebased to latest.

@ncave
Copy link
Owner Author

ncave commented Sep 25, 2019

@alfonsogarciacaro Rebased to latest.

ncave referenced this pull request in fable-compiler/Fable Sep 26, 2019
@alfonsogarciacaro
Pass otherFSharpOptions to fable-standalone
565bf9f
ncave pushed a commit that referenced this pull request Jan 17, 2020
@cartermp
Replace (nearly) all ref cells in the compiler with mutable values (d…
f9ea582 
…otnet#8063)

* # This is a combination of 9 commits.
# This is the 1st commit message:

ref -> mutable in more places in the compiler

# The commit message #2 will be skipped:

# Update dependencies from https://github.com/dotnet/arcade build 20191229.1
#
# - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19629.1

# The commit message #3 will be skipped:

# Update dependencies from https://github.com/dotnet/arcade build 20191230.1
#
# - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19630.1

# The commit message #4 will be skipped:

# Update dependencies from https://github.com/dotnet/arcade build 20191231.1
#
# - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19631.1

# The commit message #5 will be skipped:

# Update dependencies from https://github.com/dotnet/arcade build 20200101.1
#
# - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.20051.1

# The commit message #6 will be skipped:

# Update dependencies from https://github.com/dotnet/arcade build 20191216.5 (dotnet#8079)
#
# - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19616.5

# The commit message #7 will be skipped:

# dispose fsi at the end of a scripting session (dotnet#8084)
#

# The commit message #8 will be skipped:

# Added static link tests and extended CompilerAssert (dotnet#8101)
#
# * Changed CompilerAssert to static class. Added Compile/Execute methods that take a Compilation description. Added static link tests
# 
# * Hiding compilation description internals
# 
# * Added another test to check for sanity
# 
# * Making a few optional parameters
# 
# * Hiding internals of CompilationReference

# The commit message #9 will be skipped:

# Parameterize product version (dotnet#8031)
#
# * Parameterize Product details
# 
# * fcs
# 
# * Repack pkgdef

* no ilread
@ncave ncave force-pushed the export branch 5 times, most recently from cead278 to e4eeb2b Compare April 7, 2020 18:54
@ncave
Copy link
Owner Author

ncave commented Apr 13, 2020

Rebased to latest.

@ncave ncave changed the base branch from master to main June 15, 2020 22:07
@ncave
Copy link
Owner Author

ncave commented Oct 2, 2020

Rebased to latest.

@ncave ncave force-pushed the export branch 2 times, most recently from 17b56ec to 0187be3 Compare October 4, 2020 23:35
@ncave ncave force-pushed the export branch 3 times, most recently from 002bd86 to 4f4a8a8 Compare November 3, 2020 02:08
@ncave
Copy link
Owner Author

ncave commented May 16, 2021

Rebased to latest.

@ncave ncave force-pushed the export branch 4 times, most recently from bbd901a to eaeca04 Compare November 15, 2021 12:45
@ncave
Copy link
Owner Author

ncave commented Nov 16, 2021

Rebased to latest.

@ncave ncave force-pushed the export branch 2 times, most recently from 30428ac to 428d76a Compare June 25, 2022 18:38
@ncave
Copy link
Owner Author

ncave commented Jun 25, 2022

Rebased to latest. Now saving as reference assemblies, instead of just metadata-only.
In the end, the difference in size (of reference assemblies vs metadata-only) is very small, but still a bit better.

@ncave
Copy link
Owner Author

ncave commented Jul 3, 2022

Now saving as reference assemblies
Switched back to exporting metadata (instead of reference assemblies), as reference assemblies seem to be missing some methods. The difference in binary size is pretty small anyway.

@dsyme
Copy link

dsyme commented Jul 3, 2022

Do you have any more information about missing methods?

@ncave
Copy link
Owner Author

ncave commented Jul 3, 2022

@dsyme See dotnet#13433

@ncave ncave force-pushed the export branch 4 times, most recently from b7b43f0 to 984e854 Compare August 26, 2022 21:21
@ncave ncave force-pushed the export branch 2 times, most recently from 01dfd64 to 4142d82 Compare November 30, 2022 19:52
@ncave ncave mentioned this pull request Jan 26, 2023
Open
@ncave ncave marked this pull request as draft March 14, 2023 17:48
@ncave ncave mentioned this pull request Oct 2, 2023
Open
@ncave ncave force-pushed the export branch 2 times, most recently from 2bfe950 to 44f65e7 Compare October 19, 2023 17:59
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 8, 2023

❗ Release notes required

@ncave,

Caution

No release notes found for the following paths.

Please make sure to add an entry with short succint description of the change as well as link to this pull request.

Examples:
- Respect line limit in quick info popup - https://github.com/dotnet/fsharp/pull/16208
- More inlines for Result module - https://github.com/dotnet/fsharp/pull/16106
- Miscellaneous fixes to parens analysis - https://github.com/dotnet/fsharp/pull/16262

If you believe that release notes are not necessary for this PR, please add "NO_RELEASE_NOTES" label to the pull request.

You can open this PR in browser to add release notes: open in github.dev

Change path Release notes path Description
src/Compiler docs/release-notes/FSharp.Compiler.Service/8.0.200.md No release notes found or release notes format is not correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ncave @alfonsogarciacaro @dsyme