ngs-java: replace only version suffix. #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only the version suffix should be substituted, not any occurrence of the version number (e.g. in a directory name).
|
If there are any objections against this patch, please let me know. This patch is necessary to fix build problems on systems using functional package management. |
|
LGTM although I don't have merge rights. I'm curious what functional package managers does this not work on? Nix? |
|
I've packaged it for GNU Guix which reuses the Nix daemon. As the output directory is |
|
Please let me know if you want me to change anything about this patch. I'd very much like to see the build system fixed upstream. |
|
Thank you for the patch. We will add it to the next release. |
klymenko
added a commit
that referenced
this pull request
May 28, 2015
ngs-java: replace only version suffix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only the version suffix should be substituted, not any occurrence of the version number (e.g. in a directory name). The latter is a problem when installing symlinks to a directory that happens to contain the version number string in its name.