We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In pgap.py's make_podman_cmd, the parameter --container-name is only respected if debug is True. The indentation is wrong imo:
pgap.py
make_podman_cmd
--container-name
debug
True
def make_podman_cmd(self): ... if self.params.args.debug: log_dir = self.params.outputdir + '/debug/log' os.makedirs(log_dir, exist_ok=True) self.cmd.extend(['--volume', '{}:/log/srv'.format(log_dir)]) if self.params.args.container_name: self.cmd.extend(['--name', self.params.args.container_name]) self.cmd.append(self.params.docker_image)
Should be:
The text was updated successfully, but these errors were encountered:
Hi, Thomas! Thank you for your report. Have you tried our October/2023 version? We fixed it according to our release notes.
Sorry, something went wrong.
Yes, it works!
Excellent! Thanks for confirming, Thomas!
No branches or pull requests
In
pgap.py
'smake_podman_cmd
, the parameter--container-name
is only respected ifdebug
isTrue
. The indentation is wrong imo:Should be:
The text was updated successfully, but these errors were encountered: