Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output formats added for query - CSV/JSON #111

Merged

Conversation

dhruvjain92
Copy link

No description provided.

@ncc-erik-steringer ncc-erik-steringer changed the base branch from master to v1.2.0-dev March 30, 2022 18:45
@ncc-erik-steringer
Copy link
Collaborator

This is definitely a good idea. The commits seem to have a lot of style changes and the target was master, so I'll need to move some things around (resolve conflicts) to make this work.

@dhruvjain92
Copy link
Author

@ncc-erik-steringer Sorry for the style changes but I realized too late that my autoformatter was on and it did those changes.

Btw, I tried this tool and infrastructure team asked for a CSV and that's when I added this code. I might contribute whenever I can think of an idea.(will make sure to keep my formatter off next time :))

@ncc-erik-steringer ncc-erik-steringer changed the base branch from v1.2.0-dev to v1.2.0-dev-query-outputs March 30, 2022 23:40
@ncc-erik-steringer ncc-erik-steringer merged commit e929b7a into nccgroup:v1.2.0-dev-query-outputs Mar 30, 2022
wdahlenburg pushed a commit to wdahlenburg/PMapper that referenced this pull request Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants