Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move document.ready() functionality to separate function #182

Merged
merged 3 commits into from
Feb 14, 2019

Conversation

x4v13r64
Copy link
Collaborator

@x4v13r64 x4v13r64 commented Feb 14, 2019

This is a small PR, all it does is move the content of $(document).ready() to a separate function. It also moves hidePleaseWait() to the end of load_metadata().

This is required for the managed service, because the JSON/JS is loaded asynchronously, so we need to call the content of $(document).ready() once the JS has been loaded.

@codecov-io
Copy link

Codecov Report

Merging #182 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #182   +/-   ##
========================================
  Coverage    30.02%   30.02%           
========================================
  Files           68       68           
  Lines         4420     4420           
========================================
  Hits          1327     1327           
  Misses        3093     3093

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e10585c...f0061d9. Read the comment docs.

1 similar comment
@codecov-io
Copy link

codecov-io commented Feb 14, 2019

Codecov Report

Merging #182 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #182   +/-   ##
========================================
  Coverage    30.02%   30.02%           
========================================
  Files           68       68           
  Lines         4420     4420           
========================================
  Hits          1327     1327           
  Misses        3093     3093

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e10585c...f0061d9. Read the comment docs.

@x4v13r64 x4v13r64 merged commit 0377486 into develop Feb 14, 2019
@x4v13r64 x4v13r64 deleted the scoutsuitejs-minor-change branch February 14, 2019 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants