Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can now choose if thresholds for firm are left or right aligned #118

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

nicholasloveday
Copy link
Collaborator

No description provided.

@nicholasloveday nicholasloveday linked an issue Dec 4, 2023 that may be closed by this pull request
@nicholasloveday nicholasloveday marked this pull request as ready for review December 4, 2023 01:04
Copy link
Collaborator

@DerynGriffiths DerynGriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't been through the tests. Let me know if you want me to do that.

src/scores/categorical/multicategorical_impl.py Outdated Show resolved Hide resolved
src/scores/categorical/multicategorical_impl.py Outdated Show resolved Hide resolved
@nicholasloveday nicholasloveday force-pushed the 65-add-left-or-right-endpoints-option-to-firm branch from 9663751 to 6dd7f45 Compare December 6, 2023 00:20
@nicholasloveday
Copy link
Collaborator Author

Thanks @DerynGriffiths , I've updated it with your suggestions.

@nicholasloveday nicholasloveday force-pushed the 65-add-left-or-right-endpoints-option-to-firm branch from 6dd7f45 to 07226a9 Compare December 6, 2023 00:37
@tennlee tennlee merged commit 4329aef into develop Dec 8, 2023
6 checks passed
@tennlee tennlee deleted the 65-add-left-or-right-endpoints-option-to-firm branch May 9, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add left or right endpoints option to FIRM
3 participants