-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added interval twCRPS for ensembles #682
Added interval twCRPS for ensembles #682
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really minor feedback re. adding page numbers to reference. That's very handy an open access article just came out!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nicholasloveday , looks good. Just a few comments about the docstring. General comment: I think we need to keep working hard to distinguish between threshold weights and weights applied in a weighted mean of scores
cc @tennlee , so you know I've done the review
Thanks for the feedback @Steph-Chong and @rob-taggart. I have updated the branch with your suggestions. |
I have added a convenience function for calculating the twCRPS for an interval. This pull request just shows works with a single interval. The future twCRPS tutorial notebook will show how to work with multiple intervals.
Development for new xarray-based metrics
reduce_dims
,preserve_dims
, andweights
args.Testing of new xarray-based metrics
xr.Dataarrays
andxr.Datasets
Documentation