Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix support for jQuery 3.0.0 and build tool to minify scrollme #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dotnetCarpenter
Copy link

This fixes #34

Tested in Chrome 50 and Firefox 47

This features a simple build tool (uglify2) - just run the command npm run build to get a minified version of jquery.scrollme.js. Based on npm, so there is now a package.json.

Other fixes include, pointing bower main to an unminified version per specification and only running the initialization code once.

The version has been bumped to version 1.1.1 - so all you need to do is git tag v1.1.1 -am "Support for jQuery3" && git push --tag

Cheers!

PS. We will run off our fork (https://github.com/Firefund/scrollme) until this is merged.
My commit (c5ed23a) is signed with my public pgp key if you want to verify (github should already be doing this - if you look in the commit history) you can download my key from https://github.com/Firefund/frontend/blob/master/MAINTAINERS/dotnetCarpenter.asc

@jonsuther
Copy link

Thanks! Fixed my issue.

@subhasisghosal
Copy link

I've downloaded the version you fixed. But still it's not working. Do I have to copy any file other than jquery.scrollme.js? I'm using gulp to build the minification.

@dotnetCarpenter
Copy link
Author

@subhasisghosal Not sure what error you are getting. So can't tell you. But no, you would normally not need anything else than https://github.com/Firefund/scrollme/blob/jquery3/jquery.scrollme.js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not working with jQuery 3.0.0
3 participants