Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aclfile support #12

Merged
merged 5 commits into from
Apr 18, 2024
Merged

aclfile support #12

merged 5 commits into from
Apr 18, 2024

Conversation

ncode
Copy link
Owner

@ncode ncode commented Apr 18, 2024

  • The behavior of sync is something idiotic if you restart redis fast enough that a new master is not elected and all users get removed, so I'm adding support for aclfile and then it works as expected even after restarts

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 10.34483% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 81.15%. Comparing base (510274c) to head (778b908).

Files Patch % Lines
pkg/aclmanager/aclmanager.go 10.34% 24 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #12       +/-   ##
===========================================
- Coverage   93.90%   81.15%   -12.76%     
===========================================
  Files           1        1               
  Lines         164      191       +27     
===========================================
+ Hits          154      155        +1     
- Misses          7       31       +24     
- Partials        3        5        +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ncode ncode merged commit f02890e into main Apr 18, 2024
3 checks passed
@ncode ncode deleted the juliano/aclfile branch April 18, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants