Update USER and LOGNAME environmental variables #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings down `su-exec` to 11kB and `su-exec-static` to 853kB on my Ubuntu 16.04 x86_64.
Static linking to GNU libc is not really allowed, and I am using GNU libc for my purposes (running Java on CentOS and Fedora). Being able to do "make install" makes packaging su-exec as an RPM easier.
http://www.linuxjournal.com/article/1158 used as reference.
Addresses ncopa#7
The far most likely cause for EPERM is that people try to run su-exec as a non-root user, so help them understand this is not possible.
|
@hlovdal: Your PRs need to be atomic, man. I know this project seems abandoned, but as a maintainer of other projects, I can assure you that I'd never approve this PR as is. |
|
Ignoring the dependency for pull request 16, it is very atomic. Pull request 16 includes all but the last three commits:
but, yes diffing everything to the current master most certainly looks like a mess. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update USER and LOGNAME environmental variables. This addresses issue 8.
This pull request builds on top of pull request 16, but since that pull request is not merged yet, the diff to master will include too much. I'll happily rebase when that is merged.