-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies to angular 13 #235
Conversation
I added some auto commits to master. Can you please fix package-lock? |
|
Sorry, I haven't found the time yet to do it.
…On Tue, Apr 19, 2022, 14:41 Ovi Trif ***@***.***> wrote:
Can you please fix package-lock? Thanks for the PR!
What needs to be fixed to package-lock, I may jump in to do it 😅
—
Reply to this email directly, view it on GitHub
<#235 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHKRXUYVLSXT5YLCWDXOBDVF2SYDANCNFSM5NVES6KQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
No worries, ok if I try to fix |
No, delete the file then install and make sure tests run. Then just push the updated file. Need to make sure it is off of latest master. Thanks! |
Thank you @isaackehle! 🙇 U saved me, I've been going through every change and trying to make sense of it, and you know the file has over 27k lines of code 😅 |
Oh for sure. Yeah that file is great for making sure we have the exact packages that work well together. Thanks for handling it! |
@isaackehle I opened another PR from my fork to address issue #234: #247 Can you please check it? Thanks in advance 🙇 |
Closing in favor of #250 |
No description provided.