Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies to angular 13 #235

Closed
wants to merge 2 commits into from
Closed

Conversation

oriolj
Copy link
Contributor

@oriolj oriolj commented Feb 6, 2022

No description provided.

@isaackehle
Copy link
Member

I added some auto commits to master. Can you please fix package-lock?
Thanks for the PR!

@isaackehle isaackehle mentioned this pull request Apr 14, 2022
@ovitrif
Copy link
Contributor

ovitrif commented Apr 19, 2022

Can you please fix package-lock? Thanks for the PR!
What needs to be fixed to package-lock, I may chip in to do it 😅

@oriolj
Copy link
Contributor Author

oriolj commented Apr 19, 2022 via email

@ovitrif
Copy link
Contributor

ovitrif commented Apr 19, 2022

Sorry, I haven't found the time yet to do it.

No worries, ok if I try to fix package-lock although I'm not sure what's needed and open another PR?

@isaackehle
Copy link
Member

No, delete the file then install and make sure tests run. Then just push the updated file. Need to make sure it is off of latest master.

Thanks!

@ovitrif
Copy link
Contributor

ovitrif commented Apr 20, 2022

No, delete the file then install and make sure tests run. Then just push the updated file. Need to make sure it is off of latest master.

Thank you @isaackehle! 🙇

U saved me, I've been going through every change and trying to make sense of it, and you know the file has over 27k lines of code 😅

@isaackehle
Copy link
Member

Oh for sure. Yeah that file is great for making sure we have the exact packages that work well together. Thanks for handling it!

@ovitrif
Copy link
Contributor

ovitrif commented Apr 20, 2022

@isaackehle I opened another PR from my fork to address issue #234: #247

Can you please check it? Thanks in advance 🙇

@isaackehle
Copy link
Member

Closing in favor of #250

@isaackehle isaackehle closed this May 6, 2022
@isaackehle
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants