fix: mitigate floating point issues #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndavd
force-pushed
the
fix/floating-point
branch
from
b703738
to
2506352
Compare
|
After applying a correction to the cube's positions after every full rotation noticed that if more than 1 rotation happens on the same dimension we get a jump.. Perhaps the issue is deeper |
ineiti
reviewed
Dec 20, 2023
ndavd
force-pushed
the
fix/floating-point
branch
from
2506352
to
38dd496
Compare
ndavd
force-pushed
the
fix/floating-point
branch
from
38dd496
to
d3f6927
Compare
feat: add more vec operations chore: remove ncube correction as it won't work on complex rotations closes #10
ndavd
force-pushed
the
fix/floating-point
branch
from
d3f6927
to
dc590da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10