Add support for Python scripts #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vogtinator
reviewed
Jun 20, 2024
Vogtinator
reviewed
Jun 21, 2024
Vogtinator
approved these changes
Jul 5, 2024
|
Code looks good, I also verified that the output of ndless/calcbin remains identical. I actually wanted to squash merge instead of rebase merge, but that shouldn't matter much anyway 🤷 |
|
Just mentioning here that thanks to this PR, I've now added support for TI-Nspire CX II python scripts to TI-Planet's Project Builder, thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added support for Python scripts. You can add multiple Python files. The first one specified will be the one that shows up when the TNS document is opened.
Should I add some code to validate the filename? I believe the part before the .py extension cannot exceed 237 characters, and must be a valid Python identifier (only alphanumeric/underscore characters, can't start with a digit, can't be a reserved word).