Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some warnings, add meaningful errors #26

Merged
merged 1 commit into from
Sep 10, 2020

Conversation

ndrsllwngr
Copy link
Owner

@ndrsllwngr ndrsllwngr commented Sep 9, 2020

APPROACH
  • PR points at Feature/lenses #25
  • renamed board to board_ to fix shadowing
  • commented out unused parts of code in Application.hs, it was not in the MongoDB template, but I wanted at first to make use of it. let's see if we have time to include or evaluate it.
  • changed undefined to error "msg" to provide meaningful feedback, e.g. in the Example the action Type is wrong
09/Sep/2020:23:01:49 +0200 [Error#yesod-core] Invalid MoveRequest.
CallStack (from HasCallStack):
  error, called at src/Marshalling.hs:92:25 in minesweepskell-0.1.0-8uy8wOlansCFGGguNCw8nf:Marshalling @(yesod-core-1.6.18-1gehdd9uaBvCwfXwrHEsNB:Yesod.Core.Class.Yesod src/Yesod/Core/Class/Yesod.hs:688:5)
PUT /game/freeletics
  Request Body: {"action":"Reasdfasfdveal","coordX":1,"coordY":6}
  Accept: */*
  Status: 500 Internal Server Error 0.008828s

@ndrsllwngr ndrsllwngr changed the title Fix most warnings, add meaningful errors Fix some warnings, add meaningful errors Sep 9, 2020
@ndrsllwngr ndrsllwngr mentioned this pull request Sep 9, 2020
46 tasks
@griase94 griase94 merged commit 7b7f79a into feature/lenses Sep 10, 2020
@griase94 griase94 deleted the bugfix/warnings-errors branch September 10, 2020 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants