Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to choose random seed incl. fallback in backend #29

Merged
merged 3 commits into from
Sep 11, 2020

Conversation

ndrsllwngr
Copy link
Owner

@ndrsllwngr ndrsllwngr commented Sep 11, 2020

TODO
  • fix error if "seed": null in backend and generate fallback random seed
POST /games
  Request Body: {"height":10,"width":10,"bombCount":20,"seed":null,"gameId":"noSeedProvidedByUser"}
  Accept: */*
  Status: 400 Bad Request 0.001915s

@ndrsllwngr
Copy link
Owner Author

@griase94 If you have time, I added a todo where in the code you could implement a fallback random seed generator.

@ndrsllwngr ndrsllwngr mentioned this pull request Sep 11, 2020
46 tasks
@ndrsllwngr
Copy link
Owner Author

That was quick, nice @griase94

@griase94
Copy link
Collaborator

That was quick, nice @griase94

As call-a-pizza cartons say: "Kommt schnell, kommt gut"

@ndrsllwngr
Copy link
Owner Author

Haha @griase94 , I just tested it. Works fine. 💪

@ndrsllwngr ndrsllwngr merged commit b7396d5 into develop Sep 11, 2020
@ndrsllwngr ndrsllwngr deleted the feature/random-seed branch September 11, 2020 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants