Feature/visibility #100
Feature/visibility #100
Conversation
ndrsllwngr
commented
Jan 20, 2021
•
ndrsllwngr
commented
- Move db logs in useSingleMeme to finally promise
- Fix linter warning
- Add UnauthorizedPage /403
- Add auth verification on /meme/[id] for private memes
- Clear singlememeContext properly while routing to another page
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/ndrsllwngr/omm/nc0ku6816 |
📝Changed routes:
Commit 3ce5477 (https://omm-nc0ku6816.vercel.app). |
![Screenshot of /meme/[id]](https://images.weserv.nl?url=https://s.microlink.io/VRT3YGLMVQ_nF4aPo4Y9zk9sj8c_.png&w=600)
| }) | ||
| } | ||
| } | ||
| }, [router, currentMeme, updateCurrent]) |
There was a problem hiding this comment.
Added this useEffect which is similar to the one we have in the autoplayContext. Otherwise we would get a short flash of the old currentMeme when visiting from another page. This useEffect clears the context properly if the user leaves /meme/[id].
components/Slideshow.js
Outdated
| {meme.visibility === VISIBILITY.PUBLIC && ( | ||
| <> | ||
| {prevMeme && prevMeme.id ? ( | ||
| <SlideshowButton name="prev" changeSlide={prevMeme.id} /> | ||
| ) : ( | ||
| <SlideshowButton name="prev" disabled={true} /> | ||
| )} | ||
| {nextMeme && nextMeme.id && meme.visibility === VISIBILITY.PUBLIC ? ( | ||
| <SlideshowButton name="next" changeSlide={nextMeme.id} /> | ||
| ) : ( | ||
| <SlideshowButton name="next" disabled={true} /> | ||
| )} | ||
| </> | ||
| )} |
There was a problem hiding this comment.
Not really sure if this matches all cases
There was a problem hiding this comment.
I understand the outer condition but not the inner one with "meme.visibility === VISIBILITY.PUBLIC"
There was a problem hiding this comment.
Good catch @maxrawlinger the inner is legacy code from an earlier attempt. I am going to remove it!
| }) | ||
| } | ||
| } | ||
| }, [router, currentMeme, updateCurrent]) |
