-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Facilitate erdblick web deployment #101
Conversation
7d0dd1f
to
d0f5e59
Compare
@josephbirkner Is there something like this that can be done to the native Cesium repo build to get the workers inlined into the build that can be imported as ESM? Apologies for the question as I'm new to the javascript bundlers and all their configurations. I tried building this repo with ./erdblick_app/app/app.component.ts:4:0-68 - Error: Module not found: Error: Can't resolve '../../build/libs/core/erdblick-core' in 'D:\CesiumTest\erdblick-switch-cesium-build\erdblick_app\app' Error: erdblick_app/app/app.component.ts:6:70 - error TS2307: Cannot find module '../../build/libs/core/erdblick-core' or its corresponding type declarations. 6 import MainModuleFactory, {Feature, MainModule as ErdblickCore} from '../../build/libs/core/erdblick-core'; |
…tile requests. Do not abort and re-request the same set tiles.
Hi Ashely, yes, I think our solution will also work for you. Building Erdblick can be done by following these instructions. Erdblick uses cmake and emscripten to compile its core library to web assembly, hence the errors you are seeing. |
Using cmake 3.25.3 (mac os): -- Could NOT find PythonInterp (missing: PYTHON_EXECUTABLE) |
@ashley-mort I summarized our solution here: CesiumGS/cesium#11519 (comment) That will probably be more helpful for you 🚀 |
The ESM Cesium Module, which is used by default with Typescript/Webpack, has over 100 worker source files outside of the cesium sources. Loading these creates a load of overhead and load balancing throttling on viewer.nds.live. By switching to the non-ESM sources, we can take advantage of the inlined worker sources in the Cesium.js bundle. This has the added benefit of reducing load times. See CesiumGS/cesium#11519
Closes #102