Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal Model Refactoring #104

Merged
merged 14 commits into from
Apr 17, 2024
Merged

Internal Model Refactoring #104

merged 14 commits into from
Apr 17, 2024

Conversation

Waguramu
Copy link
Contributor

Add core service. Refactor view. Refactor map service. Add view service.

@Waguramu Waguramu self-assigned this Mar 28, 2024
josephbirkner
josephbirkner reviewed Mar 28, 2024
View reviewed changes
erdblick_app/app/debugapi.component.ts Outdated Show resolved Hide resolved
erdblick_app/app/map.panel.component.ts Outdated Show resolved Hide resolved
erdblick_app/app/view.service.ts Outdated Show resolved Hide resolved
josephbirkner
josephbirkner reviewed Mar 28, 2024
View reviewed changes
erdblick_app/app/erdblick.model.ts Outdated Show resolved Hide resolved
erdblick_app/app/view.component.ts Outdated Show resolved Hide resolved
erdblick_app/app/app.module.ts Outdated Show resolved Hide resolved
@Waguramu
Copy link
Contributor Author

Waguramu commented Mar 28, 2024 •
edited by josephbirkner
Loading

  • Remove ViewService in favour of ParametersService
  • Remove MapService in favour of ParametersService
  • Remove MapModel in favour of MapService
  • [ ] Sort .ts files into directories?
  • Test whether everything works

@josephbirkner josephbirkner changed the title Very Drafty Internal Model Refactoring Apr 15, 2024
@josephbirkner josephbirkner marked this pull request as ready for review April 15, 2024 10:50
josephbirkner
josephbirkner approved these changes Apr 17, 2024
View reviewed changes
Copy link
Collaborator

@josephbirkner josephbirkner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@Waguramu Waguramu merged commit 095e5d0 into main Apr 17, 2024
1 check passed
@Waguramu Waguramu deleted the core-service branch April 17, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephbirkner josephbirkner josephbirkner approved these changes

Assignees

@Waguramu Waguramu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Waguramu @josephbirkner