Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attribute Visualization #107

Merged
merged 7 commits into from
Apr 19, 2024
Merged

Attribute Visualization #107

merged 7 commits into from
Apr 19, 2024

Conversation

josephbirkner
Copy link
Collaborator

@josephbirkner josephbirkner commented Apr 12, 2024

This PR introduces the aspect: attribute option for Erdblick styles. This allows styling rules to be written for attributes and their associated validity geometries.

@MisterGC
Copy link
Contributor

MisterGC commented Apr 16, 2024

Feedback (in progress):

Things I have tried:

  • colors based on the layer
  • labelexpression using name and layer
  • used in combination with filters to select specific subset of features
  • filter by attribute type

Questions & Suggestions that came up:

  • when I use the offset in the attribute visualization the first attribute validity visu is another selection proxy for the feature inspection but the other validities are not selectable (fix now)

  • the docs mention explicit access to value attrs (like speedLimitKmh) - but I needed to prepend **. - this also allowed me to access all attribute value in a generic way **.attributeValue.* (depending on the attr value structure) (fixed, docs updated)

    image
  • Using string concatenation within the label-text-expression with any segment evaluated to null leads to a label showing null better would that a null value would be just implicitly convert to a string (create simfil issue)

  • Not seeing the validity (geometry) in attribute inspection makes it hard - if the feature is fully covered this should be also indicated (upcoming release: expose NDS.Live validities explicitly)

  • Completion is missing for multiple keywords: attribute-type, attribute-layer-type, color-expression - first I thought it is because of - but e.g. label-text-expression works just fine (upcoming release: reflect all keywords in completion cfg)

  • How can users investigate if the validity in the underlying NDS.Live data was correct? There are currently no points or percentages which have to be used for many cases to confirm (HD) validities (main concern fixed with exposing NDS.Live validities in inspection, create issue regarding visual comparison for shape points)

  • Is it possible to add functionality that allows user to select valdities and see the corresponding entries in the inspection? (plan bidirectional nav in the scope of inspection panel epic)

  • There are style expressions that lead to a broken session, I have tried label-text-expression: "$name + select(arr(': ',''),(**.attributeValue.*) as string) + **.attributeValue.* as string" which does not make much sense but other expressions that don't work can be fixed afterwards, this one demands a new session/reload TODO: Refine, add more context, example for breaking error and recoverable error. Create a dedicated erdblick issue.

@MisterGC
Copy link
Contributor

When using offset it seems it not only applies to axis - I'd expect to get stretches fully covering the feature geometry just with an offset to the side:

image

Copy link
Contributor

@MisterGC MisterGC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By Merlin’s beard, this PR is charmed 🪄

@josephbirkner josephbirkner merged commit 813abf8 into main Apr 19, 2024
1 check passed
@josephbirkner josephbirkner deleted the validity-visualization branch April 19, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants