Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Loading issues on malformed parameters #109

Merged
merged 16 commits into from
Apr 19, 2024
Merged

Fix: Loading issues on malformed parameters #109

merged 16 commits into from
Apr 19, 2024

Conversation

Waguramu
Copy link
Contributor

Goal: prevent app/data loading issues when already saved parameters are malformed if the definitions were changed or updated.

Scope:

  • Parameters service.

Deliverables:

  • Validation code for parsed parameters.

How to test:

  1. Build with as usual.
  2. Serve with mapget.

Notes:

  • Added missing properties/keywords for editor autocomplete.

@Waguramu Waguramu self-assigned this Apr 18, 2024
@Waguramu
Copy link
Contributor Author

Waguramu commented Apr 18, 2024

  • Investigate why parameters aren't always picked up form URL correctly
  • Validate query parameters as well (e.g. against RangeErrors)

Copy link
Collaborator

@josephbirkner josephbirkner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪄

@Waguramu Waguramu merged commit 81b0c45 into main Apr 19, 2024
1 check passed
@Waguramu Waguramu deleted the validate-params branch April 19, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants