Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular Transition #63

Merged
merged 51 commits into from
Dec 20, 2023
Merged

Angular Transition #63

merged 51 commits into from
Dec 20, 2023

Conversation

Waguramu
Copy link
Contributor

@Waguramu Waguramu commented Dec 6, 2023

Goal: perform transition to Angular and introduce a basic UI.

Scope:

  • Angular + Cesium + Erdblick integration.
  • Search UI.
  • Inspection panel UI.
  • Map layer view UI.
  • Settings UI.

Deliverables:

  • Angular app enclosing Cesium view and erdblick-core library.

How to test:

  1. Build with cmake per usual.
  2. Serve with mapget.

Notes:
*

@Waguramu Waguramu changed the title Angular clean Angular Transition Dec 6, 2023
@Waguramu Waguramu self-assigned this Dec 6, 2023
@Waguramu Waguramu marked this pull request as draft December 6, 2023 12:18
@MisterGC
Copy link
Contributor

Is it really necessary to have all these angular (build) cfg files on the top-level? This prevents imo devs/users to get an overview easily.

@josephbirkner
Copy link
Collaborator

Is it really necessary to have all these angular (build) cfg files on the top-level? This prevents imo devs/users to get an overview easily.

Yes, that is definitely expected by a web developer (just like CMakeLists.txt).

@Waguramu Waguramu marked this pull request as ready for review December 18, 2023 14:45
Copy link
Collaborator

@josephbirkner josephbirkner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍

@josephbirkner
Copy link
Collaborator

josephbirkner commented Dec 20, 2023

Additional small CRs:

  • The focus button is still displayed for services which do not offer any coverage info.

Plus for the future:

  • Attribute panel - expand all top-level nodes except geometry by default
  • Remember attribute panel sizes?
  • Attribute panel - show children of matched nodes in search
  • Panel layout improvements (draggability, visibility of toggle button)
  • Get rid of accordions in map layer panel.

@josephbirkner josephbirkner merged commit c780568 into main Dec 20, 2023
1 check passed
@josephbirkner josephbirkner deleted the angular-clean branch December 20, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants