Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output bad ID parts when id composition does not apply. #49

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

josephbirkner
Copy link
Contributor

This simplifies debugging when there is an exception message regarding a mismatching feature ID. Can be merged without test if CI passes.

Copy link

Package Line Rate Branch Rate Health
libs.http-datasource.src 81% 41%
libs.http-service.src 80% 42%
libs.logging.include.mapget 100% 0%
libs.model.include.mapget.model 81% 41%
libs.model.src 87% 50%
libs.service.include.mapget.service 100% 0%
libs.service.src 82% 45%
Summary 84% (1661 / 1975) 46% (1607 / 3489)

Minimum allowed line rate is 50%

@josephbirkner josephbirkner requested review from johannes-wolf, MisterGC and fklebert and removed request for l-laura December 1, 2023 13:55
Copy link
Contributor

@johannes-wolf johannes-wolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@josephbirkner josephbirkner merged commit c55d94e into main Dec 1, 2023
13 checks passed
@josephbirkner josephbirkner deleted the output-id-parts-in-error-message branch December 1, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants