Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

213: Upgrade to Kotlin 1.9.24 and Compose to 2024.05.00 #224

Merged
merged 4 commits into from
Jun 10, 2024

Conversation

DanielJette
Copy link
Contributor

@DanielJette DanielJette commented Jun 3, 2024

What does this change accomplish?

Resolves #213

  • Upgrade to Kotlin 1.9.24
  • Upgrade to Compose 2024.05.00
  • Fix warnings
  • Upgrade dependencies on sample apps

Caution

The January '24 update to Compose introduces changes to the default font padding which impacts any Compose-base tests that use text.
https://android-developers.googleblog.com/2024/01/whats-new-in-jetpack-compose-january-24-release.html

@DanielJette DanielJette force-pushed the 220-minSdkVersion branch 2 times, most recently from 241546f to 3c48725 Compare June 8, 2024 14:21
@ndtp ndtp deleted a comment from AndroidTestifyBot Jun 9, 2024
@ndtp ndtp deleted a comment from AndroidTestifyBot Jun 9, 2024
@ndtp ndtp deleted a comment from AndroidTestifyBot Jun 9, 2024
@DanielJette DanielJette changed the title 213: Upgrade to Kotlin 1.9.24 213: Upgrade to Kotlin 1.9.24 and Compose to 2024.05.00 Jun 9, 2024
@AndroidTestifyBot
Copy link
Contributor

AndroidTestifyBot commented Jun 9, 2024

✅ Success! - Legacy Sample screenshot test results

View build for commit 297c8d1

@AndroidTestifyBot
Copy link
Contributor

AndroidTestifyBot commented Jun 9, 2024

✅ Success! - Flix Sample screenshot test results

View build for commit 297c8d1

@AndroidTestifyBot
Copy link
Contributor

AndroidTestifyBot commented Jun 9, 2024

✅ Success! - Flix Library screenshot test results

View build for commit 297c8d1

@DanielJette DanielJette marked this pull request as ready for review June 10, 2024 04:48
@DanielJette DanielJette requested a review from a team June 10, 2024 04:48
@DanielJette DanielJette merged commit 88486e0 into 220-minSdkVersion Jun 10, 2024
2 checks passed
@DanielJette DanielJette deleted the 213-kotlin_upgrade branch June 10, 2024 12:59
@DanielJette DanielJette mentioned this pull request Jun 30, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants