Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vitals list can be specified as Plug options. #13

Merged
merged 1 commit into from
Jul 2, 2018

Conversation

ne-sachirou
Copy link
Owner

@ne-sachirou ne-sachirou commented Jul 2, 2018

Close #12


Migration guide

Before : (config.exs)

config :komachi_heartbeat, vitals: [ExampleVital]

After :

Plug app.

forward "/ops", to: KomachiHeartbeat, init_opts: [vitals: [ExampleVital]]

Phoenix app.

forward "/ops", KomachiHeartbeat, vitals: [ExampleVital]

@ne-sachirou ne-sachirou self-assigned this Jul 2, 2018
@ne-sachirou ne-sachirou merged commit e921e77 into master Jul 2, 2018
@ne-sachirou ne-sachirou deleted the feature/umbrella#12 branch July 2, 2018 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant