Added support for the POST requests #4

byapparov · 2017-03-12T22:02:29Z

Resolve #3

Mock full url

….json" appneded.

codecov-io · 2017-03-12T22:06:07Z

Codecov Report

Merging #4 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master     #4   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines         129    130    +1     
=====================================
+ Hits          129    130    +1

Impacted Files	Coverage Δ
R/mock-api.R	`100% <100%> (ø)`	✅

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd4fee2...ca07f47. Read the comment docs.

Improvements and version bump

nealrichardson

Great start. I think there's a little more to do here before we're done.

nealrichardson · 2017-03-14T04:15:38Z

R/mock-api.R

-    f <- buildMockURL(req$url)
-    if (req$method == "GET" && file.exists(f)) {
+    f <- buildMockURL(req$url, req$method)
+    if (req$method %in% c("GET", "POST") && file.exists(f)) {


Why only GET and POST? Particularly given #5, I think we'll want to stop checking req$method here and L50 below and allow mocks for any verb.

Yes, these checks have negative value for the package.

nealrichardson · 2017-03-14T04:15:38Z

tests/testthat/test-mock-api.R

@@ -18,10 +18,13 @@ public({
            expect_GET(GET("api/NOTAFILE/", query=list(a=1)),
                "api/NOTAFILE/?a=1")
        })
+        test_that("POST method reads from correct file", {
+          b <- POST("api/object1")
+          expect_identical(content(b), list(method="POST"))


This is a good start, but we should also have tests for (1) POST with body, (2) POST with query string, (3) POST with both.

Does API with POST with query string actually exist? What will be the acceptance for this?

I have added tests for buildMockURL. I think it easier if tests cover "units" first.

Fair point about POST with query string being uncommon/not advised, but httr::POST will do it if you ask it to:

> POST("http://httpbin.org/post", query=list(bar="foo"), config=verbose()) -> POST /post?bar=foo HTTP/1.1 -> Host: httpbin.org -> User-Agent: libcurl/7.51.0 r-curl/2.3 httr/1.2.1 -> Accept-Encoding: gzip, deflate -> Accept: application/json, text/xml, application/xml, */* -> Content-Length: 0 -> <- HTTP/1.1 200 OK <- Server: nginx <- Date: Wed, 15 Mar 2017 04:33:12 GMT <- Content-Type: application/json <- Content-Length: 415 <- Connection: keep-alive <- Access-Control-Allow-Origin: * <- Access-Control-Allow-Credentials: true <- Response [http://httpbin.org/post?bar=foo] Date: 2017-03-15 04:33 Status: 200 Content-Type: application/json Size: 415 B { "args": { "bar": "foo" }, "data": "", "files": {}, "form": {}, "headers": { "Accept": "application/json, text/xml, application/xml, */*", "Accept-Encoding": "gzip, deflate", ...

Getting the POST body into the mock URL seems more important in any case, and that's not something that buildMockURL can take currently without adding an argument. Or, we could extend buildMockURL to take a "request" object instead of a string url (or, to maintain the current API, just check the class of the object passed in, character means URL, else "response" object).

nealrichardson · 2017-03-14T04:15:38Z

tests/testthat/test-mock-api.R

        test_that("Other verbs error too", {
            expect_PUT(PUT("api/"), "api/")
            expect_PATCH(PATCH("api/"), "api/")
-            expect_POST(POST("api/"), "api/")


Why delete this? Shouldn't it still error (and thus match expect_POST) if no mock exists?

Note that the current behavior for POST requests in with_mock_API is identical to https://github.com/nealrichardson/httptest/blob/master/tests/testthat/test-without-internet.R#L33-L35. We should preserve that behavior (the error raised by stopRequest is the URL followed by the request body, if exists), and add after that the expected mock file name. If I read the code correctly, what will now happen in this PR is that the error raised would be URL, then mock file name, then request body.

I'm guessing that this means you should factor this logic out of stopRequest so that you can extend it here.

Sorry, misread this line

…sts to document expected behaivior.

nealrichardson · 2017-03-15T04:39:24Z

tests/testthat/test-mock-api.R

@@ -18,6 +18,12 @@ public({
            expect_GET(GET("api/NOTAFILE/", query=list(a=1)),
                "api/NOTAFILE/?a=1")
        })
+        test_that("POST method reads from correct file", {
+          b <- POST("api/object1", body = "", content_type_json(),


This test should fail once you include the POST body in the mock file path.

I probably would stop here for now, as it allows me to complete the outstanding tests in my packages. I think it is a different issue if anyone needs it.

nealrichardson · 2017-03-15T04:40:43Z

tests/testthat/test-mock-api.R

+  # POST method with query in URL
+  file <- buildMockURL("http://www.test.com/api/call?q=1", method = "POST")
+  expect <- "www.test.com/api/call-a3679d-POST.json"
+  expect_identical(file, expect, "POST method without query string")


Bad copy/paste of the extra label.

nealrichardson · 2017-03-15T04:43:02Z

tests/testthat/test-mock-api.R

@@ -56,3 +62,29 @@ public({
        })
    })
 })
+
+context("Mock URL")


Please help maintain consistency in the code by following the conventions that exist (four-space indentation, for one). And if you think these unit tests are worthy of their own "context", make a new file for them.

byapparov added 2 commits Feb 6, 2017

Merge pull request #1 from byapparov/mock-full-url

260c0aa

Mock full url

Added support of POST method, which will read from a file with "-POST…

Loading status checks…

d5877c7

….json" appneded.

byapparov mentioned this pull request Mar 12, 2017

Support of POST requests #3

Closed

Merge pull request #2 from nealrichardson/master

Loading status checks…

ddebcc3

Improvements and version bump

nealrichardson requested changes Mar 14, 2017

View changes

byapparov added 2 commits Mar 14, 2017

Removed checks for method, so all verbs are supported and extended te…

421ffe3

…sts to document expected behaivior.

Merge branch 'master' of github.com:byapparov/httptest

Loading status checks…

2c2ace0

nealrichardson reviewed Mar 15, 2017

View changes

Indentation and wrong label fixed.

Loading status checks…

ca07f47

nealrichardson / httptest

Added support for the POST requests #4

Added support for the POST requests #4

byapparov commented Mar 12, 2017 •

edited

codecov-io commented Mar 12, 2017 •

edited

nealrichardson left a comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

nealrichardson / httptest

Join GitHub today

Added support for the POST requests #4

Added support for the POST requests #4

Conversation

byapparov commented Mar 12, 2017 • edited

codecov-io commented Mar 12, 2017 • edited

Codecov Report

nealrichardson left a comment

This comment has been minimized.

nealrichardson Mar 14, 2017 Owner

This comment has been minimized.

byapparov Mar 14, 2017 Author Contributor

This comment has been minimized.

nealrichardson Mar 14, 2017 Owner

This comment has been minimized.

byapparov Mar 14, 2017 Author Contributor

This comment has been minimized.

byapparov Mar 14, 2017 Author Contributor

This comment has been minimized.

nealrichardson Mar 15, 2017 Owner

This comment has been minimized.

nealrichardson Mar 14, 2017 Owner

This comment has been minimized.

byapparov Mar 14, 2017 Author Contributor

This comment has been minimized.

nealrichardson Mar 15, 2017 Owner

This comment has been minimized.

byapparov Mar 15, 2017 • edited Author Contributor

This comment has been minimized.

nealrichardson Mar 15, 2017 Owner

This comment has been minimized.

nealrichardson Mar 15, 2017 Owner

This comment has been minimized.

byapparov Mar 15, 2017 Author Contributor

Essential cookies

Always active

Analytics cookies

byapparov commented Mar 12, 2017 •

edited

codecov-io commented Mar 12, 2017 •

edited

nealrichardson Mar 14, 2017
Owner

byapparov Mar 14, 2017
Author Contributor

nealrichardson Mar 14, 2017
Owner

byapparov Mar 14, 2017
Author Contributor

byapparov Mar 14, 2017
Author Contributor

nealrichardson Mar 15, 2017
Owner

nealrichardson Mar 14, 2017
Owner

byapparov Mar 14, 2017
Author Contributor

nealrichardson Mar 15, 2017
Owner

byapparov Mar 15, 2017 •

edited

Author Contributor

nealrichardson Mar 15, 2017
Owner

nealrichardson Mar 15, 2017
Owner

byapparov Mar 15, 2017
Author Contributor