Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet API #10

Closed
wants to merge 10 commits into from
Closed

Wallet API #10

wants to merge 10 commits into from

Conversation

vgrichina
Copy link

No description provided.

@render
Copy link

render bot commented May 7, 2020

@render
Copy link

render bot commented May 7, 2020

A deploy for your Render PR Server at https://nomicon-pr-10.onrender.com just failed.

View details on your dashboard at https://dashboard.render.com/static/srv-bqpqnhbeghv5i7n5cu2g.

@render
Copy link

render bot commented May 7, 2020

A deploy for your Render PR Server at https://nomicon-pr-10.onrender.com just failed.

View details on your dashboard at https://dashboard.render.com/static/srv-bqpqnhbeghv5i7n5cu2g.

@render
Copy link

render bot commented May 7, 2020

A deploy for your Render PR Server at https://nomicon-pr-10.onrender.com just failed.

View details on your dashboard at https://dashboard.render.com/static/srv-bqpqnhbeghv5i7n5cu2g.

@render
Copy link

render bot commented May 7, 2020

A deploy for your Render PR Server at https://nomicon-pr-10.onrender.com just failed.

View details on your dashboard at https://dashboard.render.com/static/srv-bqpqnhbeghv5i7n5cu2g.

@mesquka
Copy link

mesquka commented Oct 21, 2020

Just checking the status of this as I have a usecase that could benefit. The only interaction with the user's wallet in my app is calling a contract function with an attached deposit, going through the process of adding a key to the users wallet to only use once and then remove has a lot of steps that could be removed with a general purpose transaction signing function.

@mikedotexe
Copy link
Contributor

Thanks for taking a stab at this Vlad, and having the foresight in the summer of 2019. I think we'll possibly make a new NEP, using the updated process described here:
https://github.com/near/NEPs/blob/95e2db9b315c0a801659034c6b76a5895ea78d55/README.md#process

Also, I've been looking into deep linking for MetaMask, as I'm quite impressed with the product, especially the mobile app. This has led me to the parsing here:
https://github.com/MetaMask/metamask-mobile/blob/598331385e1335d12d6d8a5712ab08ef1abc3005/app/core/DeeplinkManager.js#L27-L30

which uses https://www.npmjs.com/package/eth-url-parser

I believe we can take lessons from the following Ethereum EIPs:

Our URI / deep linking will be quite different, since there are more Actions than just send or sign.
I'm also a bit hesitant to use paths like login (although we can keep this for backwards compatibility) and instead move to a system that's technically correct using Actions, perhaps camel-cased.

So:
{base-uri}/addKey?type=full&curve=ed25519&publicKey=abc…319&…

where addKey is the camel-cased version of the Action.

Now this doesn't mean that every path/slug must be an atomic Action. There will also be common needs like:

  • Offline signing (like this cookbook recipe)
  • Batch Actions in a transaction, where we'd likely send a base64-encoded message that fits some defined structure, like we already have in NEAR Wallet.
  • Other common needs…

I'm afraid I'm not terribly familiar with the NEAR Wallet codebase, but notice that there seem to be paths set up here, in case it's a useful resource for this discussion.
https://github.com/near/near-wallet/blob/0db73eef9fa21e45cf3485de93bb5f8a9cf55f20/packages/frontend/src/utils/wallet.js#L44-L49

@frol frol added the WG-wallet-standards Wallet Standards Work Group should be accountable label Sep 5, 2022
@frol
Copy link
Collaborator

frol commented Sep 30, 2022

@vgrichina Is this still relevant?

@frol frol added the S-draft/needs-author-revision A NEP in the DRAFT stage that needs an author revision. label Sep 30, 2022
@ori-near ori-near added the A-NEP A NEAR Enhancement Proposal (NEP). label Oct 13, 2022
@ori-near
Copy link
Contributor

As the moderator, I assume this PR is no longer active given that there was no activity for over two months. Therefore, I am closing it. If anyone is interested in reopening this PR, please submit a new one.

@ori-near ori-near closed this Dec 12, 2022
@ori-near ori-near added S-retracted A NEP that was retracted by the author or had no activity for over two months. and removed S-draft/needs-author-revision A NEP in the DRAFT stage that needs an author revision. labels Dec 12, 2022
@frol frol deleted the WalletAPI branch December 20, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-NEP A NEAR Enhancement Proposal (NEP). S-retracted A NEP that was retracted by the author or had no activity for over two months. WG-wallet-standards Wallet Standards Work Group should be accountable
Projects
Status: REJECTED
Development

Successfully merging this pull request may close these issues.

6 participants