(not for merge, discussion comments) enum discriminant de- and serialization behavior #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frol
requested changes
Jun 12, 2023
frol
requested changes
Jun 15, 2023
|
@iho Please, add tests to cover #148 (comment) |
frol
reviewed
Jun 19, 2023
frol
requested changes
Jun 19, 2023
There was a problem hiding this comment.
- Document
use_discriminantattribute in the README: https://github.com/near/borsh-rs#features
mina86
reviewed
Jun 19, 2023
24 tasks
iho
force-pushed
the
iho_enum_discriminant_attr_macros
branch
from
650bab0
to
2c2cb64
Compare
dj8yfo
requested changes
Jul 11, 2023
dj8yfo
requested changes
Jul 11, 2023
|
@dj8yfo done. Please look again |
dj8yfo
requested changes
Jul 12, 2023
dj8yfo
requested changes
Jul 12, 2023
dj8yfo
reviewed
Jul 12, 2023
dj8yfo
requested changes
Jul 12, 2023
dj8yfo
requested changes
Jul 12, 2023
dj8yfo
requested changes
Jul 12, 2023
dj8yfo
requested changes
Jul 12, 2023
dj8yfo
requested changes
Jul 12, 2023
dj8yfo
reviewed
Jul 13, 2023
dj8yfo
requested changes
Jul 13, 2023
dj8yfo
reviewed
Jul 13, 2023
dj8yfo
reviewed
Jul 22, 2023
|
reopening to check resolution of comments, not for merge |
dj8yfo
changed the title
|
closing as all comments have either been resolved or moved to #183 |
dj8yfo
added a commit
that referenced
this pull request
Jul 31, 2023
… behavior #148 (#183) * WIP * Update insta snapshots * clippy * clippy * Add documentation * remove debug prints; add documentation * fix doc * remove debug print * Apply suggestions from code review Co-authored-by: dj8yf0μl <26653921+dj8yfo@users.noreply.github.com> * Add test; bump Rust version in CI; fix typos * refactoring * Apply suggestion for check_item_attributes * Add docs for * remove comment; add documentation * clippy * replace panic in macros to explicit error * Apply suggestions from code review Co-authored-by: dj8yf0μl <26653921+dj8yfo@users.noreply.github.com> * fix test * Fix comments; Add suggested tests * Add documentation; Bump Rust compiler version * Apply suggestions from code review Co-authored-by: dj8yf0μl <26653921+dj8yfo@users.noreply.github.com> * Fix tests * Fix test; clippy * Apply suggestions from code review Co-authored-by: dj8yf0μl <26653921+dj8yfo@users.noreply.github.com> * Move enum related tests to separate file * fix doc CI * docs: Update "Enum with explicit discriminant" README.md * fix(ci): conditional downgrade of time for older toolchain * ci: fixed the condition on when to downgrade `time` crate in CI workflow * Fix English in doc * chore: revert unneeded imports reordering * chore: duplicate `if let Err(...)` instead of `match` --------- Co-authored-by: dj8yf0μl <26653921+dj8yfo@users.noreply.github.com> Co-authored-by: Vlad Frolov <frolvlad@gmail.com> Co-authored-by: dj8yf0μl <sffhox@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #138 (comment)
Resolves #147